Skip to content

Remove suggestions when GDT is enabled #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

Remove suggestions when GDT is enabled #246

merged 1 commit into from
Oct 21, 2025

Conversation

@JPrevost
Copy link
Member

@JPrevost JPrevost commented Oct 21, 2025 •
edited by jazairi
Loading

Why are these changes being introduced:

  • GDT views were not intended to show suggestions at this time
  • We accidentally left them in when enabling GDT because they share the same TACOS partial as regular views

Relevant ticket(s):

How does this address that need:

  • Adds a GDT feature flag check around the partial that displays suggestions in TACOS analyze view

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls
Copy link

coveralls commented Oct 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18685514089

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 98.284%
Totals Coverage Status
Change from base Build 18685404959: 0.1%
Covered Lines: 802
Relevant Lines: 816
💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-123-re-bpcfi9 October 21, 2025 12:50 Inactive
@jazairi jazairi self-assigned this Oct 21, 2025
jazairi
jazairi approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed locally that a search for 'web of sci' does not show the suggested resource in GeoData. The suggested resource renders as expected in the review app, which is configured for USE UI.

@JPrevost
Remove suggestions when GDT is enabled
b2eba16 
Why are these changes being introduced:

* GDT views were not intended to show suggestions at this time
* We accidentally left them in when enabling GDT because they share
  the same TACOS partial as regular views

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/USE-123

How does this address that need:

* Adds a GDT feature flag check around the partial that displays
  suggestions in TACOS analyze view
@JPrevost JPrevost force-pushed the use-123-remove-suggestions-from-geodata branch from 49ec58c to b2eba16 Compare October 21, 2025 13:30
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-use-123-re-bpcfi9 October 21, 2025 13:30 Inactive
@JPrevost JPrevost merged commit 8e8fb81 into main Oct 21, 2025
5 of 7 checks passed
@JPrevost JPrevost deleted the use-123-remove-suggestions-from-geodata branch October 21, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jazairi jazairi jazairi approved these changes

Assignees

@jazairi jazairi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JPrevost @coveralls @jazairi @mitlib